This repository was archived by the owner on Jul 27, 2023. It is now read-only.
docs(57): add pull request template#58
Open
resparzasoto wants to merge 2 commits into
Open
Conversation
resparzasoto
added
documentation
Contributor
|
Hey @resparzasoto any update on this one? I think that if we're rellying on the general commits and contribution guideline we should redirect there. |
Author
|
@omarefg I can edit the PR for add the files of CONTRIBUTING, CODE_OF_CONDUCT and LICENSE, what do you think? That will resolve the breaklinks and documentation in the repository. |
- CODE_OF_CONDUCT - CONTRIBUTING - LICENSE
omarefg
approved these changes
Nov 12, 2021
|
|
||
| ## Checklist ✅ | ||
|
|
||
| - [ ] I have followed the [contributor guideline](https://github.com/platzily/platzily-monolith/blob/main/CONTRIBUTING.md) |
Contributor
There was a problem hiding this comment.
Shouldn't we add a contributor guideline before mergin this PR?
| - [ ] Tests are included | ||
| - [ ] Documentation is changed or added | ||
| - [ ] Related issue has been created | ||
| - [ ] Commits messages follows [commit guideline](https://github.com/platzily/platzily-monolith/blob/main/CONTRIBUTING.md/#Commits) |
Contributor
There was a problem hiding this comment.
Same as above but for commit guideline haha
Contributor
Great, got my approve 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve pull request documentation