RowBinary: decode dynamic JSON #296
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented basic support for decoding dynamic JSON in RowBinary.
The implementation essentially skips over all the type information encoded in the type header and then passes the remaining payload to the regular JSON decoding.
The current limitations of this approach are:
typed_pathsencode the type headers of contained types. To strip the correct number of bytes, a more sophisticated approach would be necessary. I currently haveskip_type/1throw if it encounters a multi-byte type header.output_format_binary_write_json_as_string = 1. If JSON is not stringified by ClickHouse, we pass incomprehensible data toJason.decode. Unfortunately, I don't see a way of asserting correct use in code (matching on{as opening brace doesn't work since all types of JSON values can be returned)type_paths, which means that encoded Dates etc. aren't converted to the more ergonomic Elixir types. However, this is probably not a feature people expect from JSON anyways.Please let me know what you think.