Open
Conversation
…ing support - Refactored MeshInstance to include support for morph weights and skin instances. - Added instancing capabilities with vertex buffer and matrix options. - Improved validation schema for props, ensuring type safety and error messaging. - Updated internal implementation to manage lifecycle and rendering more effectively.
…registration - Removed the mesh instance registration logic and context provider from RenderComponent. - Updated the component to directly use the props for rendering without additional state management. - Retained the container rendering logic for asset types.
🦋 Changeset detectedLatest commit: 5c4072e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a declarative
<MeshInstance/>component providing a React-level abstraction over the enginesMeshInstance. It mirrors the underlying engine behaviour while fitting into the existing<Entity>/<Render>hierarchy.This will be necessary to support a better API for loading assets.
Features
Example
with instancing