fix: Apply GSplat unified property while it is disabled#299
Merged
Conversation
🦋 Changeset detectedLatest commit: 596dcc9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #297 by adding custom handling for the unified property of the GSplat component, which cannot be modified while the component is enabled due to PlayCanvas engine constraints.
Key Changes:
- Added a custom
applyfunction for theunifiedproperty that temporarily disables the component when needed to modify this restricted property - The implementation checks if the component is already disabled before toggling, avoiding unnecessary operations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
willeastcott
approved these changes
Dec 29, 2025
Contributor
Author
|
This change was committed recently: We can think about reverting this "fix" here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed?
unifiedflag not set correctly preventing LODs to be rendered correctly #297 by temporarily disabling and enabling the component while modifying theunifiedflag.unifiedprop directly into theentity.addComponenthere:react/packages/lib/src/hooks/use-component.tsx
Line 24 in 5e577ca