fix: sidebar scroll and semantic/SQL mode toggle - #3
Merged
Conversation
Grid items default to min-height:auto, which prevented the sidebar from shrinking below its content so overflow-y-auto never activated. Add min-h-0 on the sidebar column and scroll region.
DaisyUI tab classes were not styled in this Tailwind-only setup, so the mode switch looked like plain text. Use a pill segmented control with clear active state, focus rings, and aria-pressed.
Deploying d1-manager with
|
| Latest commit: |
74037ce
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2941dfa1.d1-manager-9q5.pages.dev |
| Branch Preview URL: | https://cursor-sidebar-table-scroll.d1-manager-9q5.pages.dev |
sauramel
marked this pull request as ready for review
April 12, 2026 23:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small UI fixes for the D1 manager layout and table browser.
Changes
Sidebar scrolling
The sidebar nav already used
overflow-y-auto, but as a grid child it could not shrink below the height of its content. Grid items default tomin-height: auto, which blocks overflow scrolling when the table list is taller than the viewport.min-h-0to the sidebar column and to the scrollableflex-1region in+layout.svelteso databases and tables can scroll.Semantic / SQL mode control
The previous control used DaisyUI
tabs/tabclasses, but this project uses Tailwind only (no DaisyUI), so the switch looked like unstyled plain text.type="button", andaria-pressedfor accessibility.Testing
pnpm checkstill reports existing issues inTableBrowser.svelte(types, a11y) and db pages unrelated to these markup/class changes.