Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
==========================================
- Coverage 45.74% 41.97% -3.77%
==========================================
Files 13 13
Lines 811 910 +99
==========================================
+ Hits 371 382 +11
- Misses 440 528 +88
Continue to review full report at Codecov.
|
TDiazT
reviewed
Dec 23, 2022
| { fix_id : Name.t | ||
| ; fix_body : term | ||
| ; fix_type : term | ||
| ; fix_rarg : int (* index of the recursive argument *) |
Collaborator
There was a problem hiding this comment.
Let's link the example in metacoq?
| | Ok (HInductive i), Ok (HInductive j) -> i = j | ||
| | _, _ -> assert false | ||
|
|
||
| let rec is_fix_neutral (t : term) : bool = |
Collaborator
There was a problem hiding this comment.
Maybe a small explanation as well?
| | Universe _ | Unknown (Universe _) | Err (Universe _) | Inductive _ -> true | ||
| | _ -> is_neutral term | ||
|
|
||
| let is_fix_canonical term : bool = |
| term, KCast_term (source, target) :: cont | ||
| | term, KCast_term (source, target) :: cont when is_canonical term -> | ||
| Cast { source; target; term }, cont | ||
| | term, KFix_app (fi, args) :: cont when is_canonical term -> |
Collaborator
There was a problem hiding this comment.
Maybe we can add some explanation, we didn't remember it lol
| | Match { ind; discr; z; pred; f; branches }, _ -> | ||
| discr, KMatch_discr (ind, z, pred, f, branches) :: cont | ||
| | Fixpoint fi, cont -> | ||
| let rec get_args acc n cont = |
| type i = (term, errors) result | ||
| type c = (unit, errors) result | ||
|
|
||
| let fix_guard _term = Ok () |
Collaborator
There was a problem hiding this comment.
Maybe leave this one for the next PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.