Skip to content

fix loading winfsp DLL on Windows#29

Open
cdanis wants to merge 1 commit into
pleiszenburg:developfrom
cdanis:fix-windows
Open

fix loading winfsp DLL on Windows#29
cdanis wants to merge 1 commit into
pleiszenburg:developfrom
cdanis:fix-windows

Conversation

@cdanis

@cdanis cdanis commented Jul 19, 2020

Copy link
Copy Markdown

No description provided.

cdanis added a commit to cdanis/emojifs that referenced this pull request Jul 19, 2020
this was upsettingly easy.  however, it requires a trivial patch to
reFUSE to be merged and released:
pleiszenburg/refuse#29
@cdanis cdanis changed the base branch from master to develop July 20, 2020 14:14
@cdanis

cdanis commented Jul 20, 2020

Copy link
Copy Markdown
Author

This is now against develop instead of master, sorry about that.

@cdanis

cdanis commented Aug 10, 2020

Copy link
Copy Markdown
Author

@s-m-e do you think you'll have a chance to look at this soon?

@clach04 clach04 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1 Looks good to me (without this change get sys not found traceback).

Comment thread src/refuse/_refactor.py
# +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

import os
import sys

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super pedantic; I'd be tempted to import AFTER ctypes to be more Pythnonic (alphabetical sorted imports, note existing import os could move too)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'd be happy to do either or both of those small modifications. @s-m-e do you have any thoughts?

@clach04 clach04 mentioned this pull request Sep 6, 2020
@clach04

clach04 commented Sep 6, 2020

Copy link
Copy Markdown

@cdanis I'm curious how you are testing this? I ended up with #31 from my few mins of testing seems to work.

@cdanis

cdanis commented Sep 6, 2020

Copy link
Copy Markdown
Author

@cdanis I'm curious how you are testing this? I ended up with #31 from my few mins of testing seems to work.

I did a pip install emojifs on a Windows venv and then applied the diff within the venv 😃

@cdanis

cdanis commented Oct 3, 2020

Copy link
Copy Markdown
Author

Hi @s-m-e -- I'd really like to release a Windows version of emojifs, and I would hate to needlessly fork your fork. Could you please merge this PR, or leave me a comment indicating what you'd like fixed? (Or maybe @N-Coder has commit permissions?)

@N-Coder

N-Coder commented Oct 12, 2020

Copy link
Copy Markdown

Or maybe @N-Coder has commit permissions?

Unfortunately, no. Maybe you can reach s-m-e via his e-mail address. Alternatively, you could do the same as I did while waiting for fusepy to get a new release with some bugfixes, just copy the dependency's code over to your project and comment out the dependency declaration in setup.py (effectively bundling/"vendoring" the patched dependency) until there is a new release.

@YoilyL

YoilyL commented May 24, 2022

Copy link
Copy Markdown

Alternatively, you could do the same as I did while waiting for fusepy to get a new release with some bugfixes, just copy the dependency's code over to your project and comment out the dependency declaration in setup.py (effectively bundling/"vendoring" the patched dependency) until there is a new release.

or you could monkey patch the module by injecting the sys module into the _refactor locals before importing refuse.high

import sys
from refuse import _refactor
_refactor.sys = sys
from refuse.high import FUSE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants