Skip to content

Update dependency ws to v8.20.1#1291

Open
plengauer wants to merge 1 commit into
mainfrom
renovate/ws-8.x
Open

Update dependency ws to v8.20.1#1291
plengauer wants to merge 1 commit into
mainfrom
renovate/ws-8.x

Conversation

@plengauer
Copy link
Copy Markdown
Owner

This PR contains the following updates:

Package Change Age Confidence
ws 8.20.08.20.1 age confidence

Release Notes

websockets/ws (ws)

v8.20.1

Compare Source

Bug fixes

  • Fixed an uninitialized memory disclosure issue in websocket.close()
    (c0327ec).

Providing a TypedArray (e.g. Float32Array) as the reason argument for
websocket.close(), rather than the supported string or Buffer types, caused
uninitialized memory to be disclosed to the remote peer.

import { deepStrictEqual } from 'node:assert';
import { WebSocket, WebSocketServer } from 'ws';

const wss = new WebSocketServer(
  { port: 0, skipUTF8Validation: true },
  function () {
    const { port } = wss.address();
    const ws = new WebSocket(`ws://localhost:${port}`, {
      skipUTF8Validation: true
    });

    ws.on('close', function (code, reason) {
      deepStrictEqual(reason, Buffer.alloc(80));
    });
  }
);

wss.on('connection', function (ws) {
  ws.close(1000, new Float32Array(20));
});

The issue was privately reported by Nikita Skovoroda.


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate.

@plengauer plengauer enabled auto-merge (squash) May 13, 2026 00:59
Copilot AI review requested due to automatic review settings May 13, 2026 00:59
@plengauer plengauer requested a review from moflwi as a code owner May 13, 2026 00:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ws dependency in the DiscordGateway2HTTP service to pick up the v8.20.1 patch release, which includes a security-related bug fix affecting websocket.close() when given an unsupported TypedArray reason.

Changes:

  • Bump ws from 8.20.0 to 8.20.1 in DiscordGateway2HTTP/package.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread DiscordGateway2HTTP/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants