Skip to content

Document technical limitations of shell instrumentation#2821

Merged
plengauer merged 5 commits into
mainfrom
copilot/add-limitations-section-readme
Jan 22, 2026
Merged

Document technical limitations of shell instrumentation#2821
plengauer merged 5 commits into
mainfrom
copilot/add-limitations-section-readme

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 19, 2026

  • Research and understand the limitations mentioned in the issue
  • Identify the appropriate location in README.md for the limitations section
  • Document the limitation: Functions without the function keyword whose names collide with real commands
  • Document the limitation: File descriptor conflicts (magic file descriptor 7)
  • Document the limitation: PID tracking issues when commands become functions
  • Review and refine documentation
  • Ensure documentation is clear and detailed but not overly prominent
  • Address feedback: Move shell functions and absolute paths to 1st and 2nd place as separate sections
  • Address feedback: Note shell functions as "by design"
  • Address feedback: Move PID tracking to last position
Original prompt

This section details on the original issue you should resolve

<issue_title>Document limitations</issue_title>
<issue_description>functions without function keyword whos names colide with real commands
exec file descriptor fuckery
magic filedescriptor used
saving pid and killing command kills subshell, not command because now its a function, not an external command</issue_description>

<agent_instructions>add a limitations section at an appropriate but not too prominent location in the readme and talk about these items in detail</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: plengauer <100447901+plengauer@users.noreply.github.com>
Copilot AI changed the title [WIP] Add limitations section to README Document technical limitations of shell instrumentation Jan 19, 2026
Copilot AI requested a review from plengauer January 19, 2026 19:16
Copy link
Copy Markdown
Owner

@plengauer plengauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot pls address

Comment thread README.md
Comment thread README.md Outdated
Co-authored-by: plengauer <100447901+plengauer@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 19, 2026

@copilot pls address

Both review comments have been addressed in commit 06921b8.

@plengauer plengauer marked this pull request as ready for review January 19, 2026 19:50
@plengauer plengauer requested a review from moflwi as a code owner January 19, 2026 19:50
Copilot AI review requested due to automatic review settings January 19, 2026 19:50
@plengauer plengauer enabled auto-merge (squash) January 19, 2026 19:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a comprehensive "Limitations" section to the README documenting technical constraints of the shell instrumentation system. The changes address issue #2809 by explaining scenarios where automatic instrumentation doesn't work or has known issues, along with workarounds for each limitation.

Changes:

  • Expanded the existing single-line "Limitations" section into a detailed subsection with 6 documented limitations
  • Added explanations of technical constraints including shell functions, path-based commands, file descriptor conflicts, restricted mode, and PID tracking
  • Provided workarounds for each limitation where applicable

Comment thread README.md
Comment thread README.md
@plengauer plengauer merged commit 0834d63 into main Jan 22, 2026
557 checks passed
@plengauer plengauer deleted the copilot/add-limitations-section-readme branch January 22, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document limitations

4 participants