Upgrade aiobotocore#21
Open
javiermolinar wants to merge 7 commits into
Open
Conversation
|
@javiermolinar you need to sign the Plone Contributor Agreement in order to merge this pull request. Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html |
|
@javiermolinar you need to sign the Plone Contributor Agreement in order to merge this pull request. Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html |
|
@javiermolinar you need to sign the Plone Contributor Agreement in order to merge this pull request. Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
The standard way to create aiobotocore clients is using a context manager. Since we are keeping only one instance of the client we need to use the contextlib.AsyncExitstack
Changing the way to read from streams to use aiohttp response.content
Fixing tests