chore: Add tolerance to tests#154
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @toby-coleman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the stability of the tuner integration tests. It introduces tolerance to the assertions that verify the optimal results found by the tuner, which should mitigate intermittent CI failures caused by slight variations in test outcomes. Additionally, it slightly adjusts the search space for one of the hyperparameters in the test.
Highlights
- Test Stability: Modified the
test_tuneintegration test to incorporate tolerance into assertions for the best found hyperparameter values, specifically fora.itersandc.in_1. This change aims to address intermittent failures in CI by allowing a small range of acceptable optimal results rather than strict equality. - Test Parameter Range Adjustment: Increased the upper bound of the
itershyperparameter search space from 8 to 9 within thetest_tunefunction's configuration, potentially expanding the range of values the tuner explores.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request addresses intermittent test failures in the tuner by adding tolerance to the assertions. The changes are logical and correctly implement the intended tolerance. The refactoring of the metric assertion to be dynamic is a good improvement. I've added one comment regarding the hardcoded values in the assertions, suggesting a way to make the test more maintainable and robust against future changes to the parameter search space.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Summary
Adds tolerance to tuner and RabbitMW tests that are intermittently failing in CI.
Changes