Skip to content

chore: Add tolerance to tests#154

Merged
toby-coleman merged 3 commits into
mainfrom
chore/tuner-test-tolerance
Jun 29, 2025
Merged

chore: Add tolerance to tests#154
toby-coleman merged 3 commits into
mainfrom
chore/tuner-test-tolerance

Conversation

@toby-coleman
Copy link
Copy Markdown
Contributor

@toby-coleman toby-coleman commented Jun 29, 2025

Summary

Adds tolerance to tuner and RabbitMW tests that are intermittently failing in CI.

Changes

  • Add tolerance to tuner tests.
  • Add tolerance to RabbitMQ integration tests,

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @toby-coleman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the stability of the tuner integration tests. It introduces tolerance to the assertions that verify the optimal results found by the tuner, which should mitigate intermittent CI failures caused by slight variations in test outcomes. Additionally, it slightly adjusts the search space for one of the hyperparameters in the test.

Highlights

  • Test Stability: Modified the test_tune integration test to incorporate tolerance into assertions for the best found hyperparameter values, specifically for a.iters and c.in_1. This change aims to address intermittent failures in CI by allowing a small range of acceptable optimal results rather than strict equality.
  • Test Parameter Range Adjustment: Increased the upper bound of the iters hyperparameter search space from 8 to 9 within the test_tune function's configuration, potentially expanding the range of values the tuner explores.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses intermittent test failures in the tuner by adding tolerance to the assertions. The changes are logical and correctly implement the intended tolerance. The refactoring of the metric assertion to be dynamic is a good improvement. I've added one comment regarding the hardcoded values in the assertions, suggesting a way to make the test more maintainable and robust against future changes to the parameter search space.

Comment thread tests/integration/test_tuner.py
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@toby-coleman toby-coleman changed the title chore: Add tolerance to tuner tests chore: Add tolerance to tests Jun 29, 2025
@toby-coleman toby-coleman merged commit 23bfa8f into main Jun 29, 2025
17 checks passed
@toby-coleman toby-coleman deleted the chore/tuner-test-tolerance branch June 29, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant