Conversation
Rom1-B
reviewed
Feb 26, 2025
Contributor
Rom1-B
left a comment
Rom1-B
left a comment
There was a problem hiding this comment.
I'm not a fan of this is_disclosable option. I don't think it's justified in this case to set it to true, so I'd be in favour of setting it to false.
Contributor
Author
|
now field is not disclosable, I've added the ability to clear the field |
Rom1-B
requested changes
Feb 26, 2025
inc/credential.class.php
Outdated
| { | ||
| $this->initForm($ID, $options); | ||
|
|
||
| $this->fields['password'] = (new GLPIKey())->decrypt($this->fields['password']); |
Contributor
There was a problem hiding this comment.
I don't think it's still necessary now that it's no longer on display?
Rom1-B
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Decrypt password before sending to twig (with
is_disclosable: trueforfields.passwordField)Screenshots (if appropriate):