Skip to content

PROD-5218 do not block site loading for missing tracker function - #206

Merged
michaeljguarino merged 1 commit into
mainfrom
cakinrinade/dont-block-4-oaiq
Sep 16, 2026
Merged

michaeljguarino merged 1 commit into
mainfrom
cakinrinade/dont-block-4-oaiq

Conversation

@chrisakinrinade

@chrisakinrinade chrisakinrinade commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Our site crashes when client adblockers deny the OpenAI ads measurement pixel. I updated it to fail open. Here's a side-by-side of the live site and my localhost with the fix, using the same adblockers:

image

Let me know of any consequences this might cause

Plural Flow: marketing
Plural Preview: marketing

@chrisakinrinade
chrisakinrinade requested a review from a team as a code owner September 14, 2026 21:34
@chrisakinrinade chrisakinrinade added the bug Something isn't working label Sep 14, 2026
@linear

linear Bot commented Sep 14, 2026

Copy link
Copy Markdown

PROD-5218

@plural-copilot plural-copilot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Deploy preview for marketing-pr-206 is ready!

Name Details
⚡ Service marketing-pr-206 (5 / 5 ready)
☁️ Cluster plural (eks)
:octocat: Commit sha a9e48a2
Plural URL https://console.mgmt.plural.sh/cd/clusters/446acdef-8524-425a-a49f-5336a...
🔍 Logs URL https://console.mgmt.plural.sh/cd/clusters/446acdef-8524-425a-a49f-5336a...
🌊 Flow URL https://console.mgmt.plural.sh/flows/fbbadfa5-fa67-4c16-ab32-42dca133aa3...
Preview Link Preview

You can learn more about preview environments and Plural Flows here

@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the tracker guard prevents the reported crash while preserving measurement through the existing bootstrap queue when tracking is available.

Summary

This PR prevents a missing OpenAI measurement function from crashing the site.

  • Marks window.oaiq as optional in the global TypeScript declaration.
  • Skips page-view measurement when the tracker is unavailable.
  • Preserves the existing pathname deduplication and measurement behavior when the tracker is callable.

Reviews (1) · Last reviewed commit: "do not block site loading for missing tr..."

@michaeljguarino
michaeljguarino merged commit 51c4dde into main Sep 16, 2026
10 checks passed
@michaeljguarino
michaeljguarino deleted the cakinrinade/dont-block-4-oaiq branch September 16, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants