Conversation
Add a Keyword ValueNode so quoted keyword literals like '#:foo parse and print in Racket's read form; the lexer already emitted KEYWORD tokens that parseValue had no branch for.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 73.19% 73.58% +0.38%
==========================================
Files 24 24
Lines 2108 2139 +31
Branches 290 292 +2
==========================================
+ Hits 1543 1574 +31
Misses 565 565
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeywordValueNode(analogous toSymbol) so quoted keyword literals like'#:fooparse and evaluate. The lexer already emittedTok::KEYWORDfor#:foo, butparseValuehad no branch for it, so(linklet () () '#:foo)failed to parse.parseKeywordconsumes theKEYWORDtoken; the node stores the bare keyword and prints in Racket's read form (#:foo). Keywords are not self-quoting, so the enclosingQuotedExpradds the leading quote —'#:fooprints as'#:foo, and'(#:foo 1)as'(#:foo 1).ASTVisitorinterface (Interpreter,AnalysisFreeVars).Closes #72
Test plan
ctest --preset debug— 14/14 unit tests pass, incl. new "Lexing Keyword tokens"nora-lit test/integration— 50/50 pass, incl. newquote19.rkt('#:foo) andquote20.rkt('(#:foo 1))cmake --build --preset debug— warning-clean (warnings-as-errors)clang-format— clean on all edited files