-
Notifications
You must be signed in to change notification settings - Fork 95
Remove Codesandbox1 and external API dependencies #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: abernier <76580+abernier@users.noreply.github.com>
| {title} | ||
| </a> | ||
| <span className="inline-flex gap-1"> | ||
| {boxes.map((id) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot ah shit, we needed boxes here, keep Codesandbox1 removal, but revert boxes extracted with rehype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ox component Co-authored-by: abernier <76580+abernier@users.noreply.github.com>
Co-authored-by: abernier <76580+abernier@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. |
|
@copilot peut-on generer screenshot_url a partir de l'id ? |
Oui, c'est déjà fait ! In Entries.tsx line 39, the screenshot_url is generated from the id: |
|
@copilot non mais je parlais de la prop screenshot_url du composant Codesandbox: la gwnerer automatiquement pour ne p'us avoir besoin de la passer en prop |
Co-authored-by: abernier <76580+abernier@users.noreply.github.com>
Fait ! The Codesandbox component now auto-generates screenshot_url from the id (line 32-33), so you don't need to pass it as a prop anymore. Also removed the hideTitle prop - now it just shows title/description/tags when title is provided, nothing when it's not. Changes in commit ba52920. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert we use pnpm @copilot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted .gitignore to original state (removed package-lock.json line). Changes in commit 1cbc1b8.
Co-authored-by: abernier <76580+abernier@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. |
Task Completed: Remove Codesandbox1 and External API Dependencies ✅
Summary of Changes
Successfully removed the "evolved" Codesandbox1 component that relied on external CodeSandbox API and kept the simpler Codesandbox component. Restored the boxes extraction mechanism using rehypeCodesandbox plugin.
Files Modified:
Key Improvements:
Verification
pnpm run build)pnpm run lint)Security Summary
No security vulnerabilities discovered or introduced by these changes.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.