fix: recognise renumbered EModifierValue stat types so stat_modifier_events works on build 10854 - #34
Open
ghaif wants to merge 1 commit into
Open
Conversation
stat_modifier_events and boon-dev stat-modifiers returned 0 rows on build 10854 demos. The m_eValType field (EModifierValue enum) still resolves, but the enum values were renumbered between build 10725 and 10854, so the hardcoded constants no longer matched any entry and every pickup was dropped. Match each of the six pickup stats against both the old and new eValType values. The value sets are disjoint and the array only holds these six stats, so this keeps build 10725 working and fixes 10854 with no build-number gate. Adds stat_index unit tests.
ghaif
force-pushed
the
fix/stat-modifier-events-build-10854
branch
from
August 16, 2026 17:22
2b5e6d6 to
13e3447
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
stat_modifier_eventsand theboon-dev stat-modifierscommand return 0 rows on build 10854 demos. The dataset should list permanent stat pickups (health, spirit_power, fire_rate, weapon_damage, cooldown_reduction, ammo).Cause
The field is not renamed:
m_PlayerDataGlobal.m_vecStatViewerModifierValues.{i}.{m_SourceModifierID,m_eValType,m_flValue}still resolves. TheEModifierValueenum was renumbered between build 10725 and 10854, so the hardcodedm_eValTypeconstants no longer match any entry and every pickup is dropped.Fix
Match each stat against both value sets. They are disjoint and the array only holds these six stats, so this keeps 10725 working and fixes 10854 with no build-number gate. Both the
boon-devcommand and the Python dataset are updated to stay in sync. Addsstat_indexunit tests for both value sets and an unknown value.