Fix theme toggle reliability and improve light/dark readability#121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
master-api/static/theme.jsto bind to any existing.theme-toggleelements and avoid injecting duplicate controls, and to provide a floating fallback toggle when no in-layout toggle exists.localStorage) and falling back to the system preference viaprefers-color-scheme, and synchronizedcolor-schemeviahtml.style.colorSchemewhen applying a theme..theme-icon) and legacy markup (.theme-toggle-icon) are refreshed and accessibilityaria-label/titleare kept correct after changes.master-api/static/theme.csswith higher-contrast--text-muted/--text-dimmedvalues, added floating toggle styles, legacy toggle compatibility styles, and targeted light-theme adjustments for headers, cards and sidebar items to improve overall readability.Testing
node --check master-api/static/theme.js, which completed successfully.master-api/static/theme.jsandmaster-api/static/theme.cssvia local diff inspection.Codex Task