machine/hyperV: move ssh mounts to after the ready check#28871
Open
Luap99 wants to merge 1 commit into
Open
Conversation
We are seeing frequent flakes in hyperV machine tests. The machine start fails with an ssh handshake failure: ssh: handshake failed: read tcp 127.0.0.1:56425->127.0.0.1:56377: wsarecv: An existing connection was forcibly closed by the remote host. Normally we do the ssh probe in conductVMReadinessCheck() with a retry mechanism, however because the hyperV mount code already used ssh in PostStartNetworking() we never got there and failed early. PostStartNetworking seems the wrong place to mount anyway so move this to MountVolumesToVM() instead which is placed after the ready check already so it should have a working ssh by then. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Member
Author
Member
Author
Mhh, that does not seem to work and still fails, though now with the longer retry timeout so it seem like ssh not coming up at all or a gvproxy error seems more likely. |
Contributor
|
Even if it's not fixing the issue, still LGTM for me - this is a much cleaner way of doing things and should be less race-prone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are seeing frequent flakes in hyperV machine tests. The machine start fails with an ssh handshake failure:
ssh: handshake failed: read tcp 127.0.0.1:56425->127.0.0.1:56377:
wsarecv: An existing connection was forcibly closed by the remote host.
Normally we do the ssh probe in conductVMReadinessCheck() with a retry mechanism, however because the hyperV mount code already used ssh in PostStartNetworking() we never got there and failed early.
PostStartNetworking seems the wrong place to mount anyway so move this to MountVolumesToVM() instead which is placed after the ready check already so it should have a working ssh by then.
Does this PR introduce a user-facing change?