manifest push: add --retry and --retry-delay flags#28883
Closed
medsabbar wants to merge 1 commit into
Closed
Conversation
These were already available in podman push but missing from manifest push. Wire them through so users can control retries. Fixes: podman-container-tools#28590 Signed-off-by: Mohamed Sabbar <med1sabar@gmail.com>
github-actions
Bot
added
the
kind/api-change
Author
|
/packit rebuild-failed |
Honny1
reviewed
Jun 10, 2026
|
|
||
| It("push must retry with custom retry count", func() { | ||
| SkipIfRemote("warning is not relayed in remote setup") | ||
| session := podmanTest.Podman([]string{"manifest", "create", "foo", imageList}) |
Contributor
There was a problem hiding this comment.
Please use podmanTest.PodmanExitCrearly.
Comment on lines
+368
to
+369
| Retry uint `schema:"retry"` | ||
| RetryDelay string `schema:"retryDelay"` |
Contributor
There was a problem hiding this comment.
I would use pointers when these values are optional. Then you don't need to check the query.
Contributor
|
Anyway, there is another PR that resolves this: #28637 |
Member
Well then we should close this and get the other PR over the finish line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manifest push was missing the --retry and --retry-delay options
that podman push already supports. This wires them through so
both local and remote clients can configure retry behavior.
Closes #28590