fix podman-remote save -f oci-dir/docker-dir#28903
Open
Luap99 wants to merge 2 commits into
Open
Conversation
With podman-remote we do not enter a our user namespace like we do with local podman so we keep running with the real user id. So if we then try to use chrootarchive as normal user it fails with: creating mount namespace before pivot: operation not permitted So simply revert back to the normal archive code. Now the more interesting thing is we do have a test "podman save to directory with oci format" but it never runs rootless+remote in our CI system with our current matrix as we wanted to reduce jobs. So rethink the matrix and add one such job as this shows it is needed. Fixes: 25aee24 ("use chrootarchive over plain archive package") Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added
the
No New Tests
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Contributor
|
LGTM |
So when running remote and rootless tests the buildImage() thing has one big problem because it used the main test tmpdir as context. However that dir also holds all the image layers with files that are owned by other uids and because podman-remote does not use the userns it cannot read some files and then fails when trying to tar up the context dir. To fix this use an extra sub directory. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With podman-remote we do not enter a our user namespace like we do with local podman so we keep running with the real user id.
So if we then try to use chrootarchive as normal user it fails with: creating mount namespace before pivot: operation not permitted
So simply revert back to the normal archive code.
Now the more interesting thing is we do have a test "podman save to directory with oci format" but it never runs rootless+remote in our CI system with our current matrix as we wanted to reduce jobs.
So rethink the matrix and add one such job as this shows it is needed.
Fixes: 25aee24 ("use chrootarchive over plain archive package")
Does this PR introduce a user-facing change?