Skip to content

Conversation

@f0lkert
Copy link

@f0lkert f0lkert commented Apr 8, 2025

hello,

when the rspamd milter_headers module is configured to add headers to all scanned messages, like this:

extended_spam_headers = true;
use = ["add-headers", "x-spam-status", "x-spamd-result", "x-rspamd-server",  "x-rspam-action" ];

the filter-rspamd filter does not pass on the additional headers to smtpd.

this PR fixes that, alas likely not in the proper way. I have merely extended the hdrs literal with the variousX-Spam-* X-Spamd-* and X-Rspamd-* headers, hence those get processed the same way as the ARC-* headers.

this patch has only been tested on my own systems and might well have some hidden side effects i am not aware of. it does, however, now successfully pipe through all headers added by rspamd to smtpd.

please let me know if you have any concerns with this approach!

thank you for your contributions to the smtpd stack! =)

@dlatchx
Copy link

dlatchx commented Apr 16, 2025

Doesn't #52 achieve the same thing?
It should be more generic

@f0lkert
Copy link
Author

f0lkert commented Apr 17, 2025

Doesn't #52 achieve the same thing? It should be more generic

hehe yes indeed, i only noticed that PR when i had already hacked together a quick fix...

PR #52 works fine on my site as well, so please ignore my PR #53. I would recommend to merge #PR 52 instead, so that the opensmtpd-filter-rspamd package will pass on the rspam headers to smtpd.

many thanks!
/f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants