Conversation
leviport
previously approved these changes
Aug 31, 2026
leviport
left a comment
leviport
left a comment
Member
There was a problem hiding this comment.
Working as expected, and I'm not seeing any regressions with the magnifier. Thanks!
wash2
previously approved these changes
Aug 31, 2026
Member
|
This PR needs to be rebased |
**Changes UI:** Adds 10% and 75% zoom increments approved by UX in #2615. Replaces hard-coded zoom increment list with new ZoomConfig::ZOOM_INCREMENT_PRESETS const. Bumps cosmic-comp-config to 738e0b3 (merged #2616). - Side effect: Bumps libcosmic 2a73fbc to caec74c. Follows up on #2616. AI-assisted: unsolicited edit by Claude AI; reviewed and approved by author.
tgrushka
force-pushed
the
refactor-magnifier-zoom-increments
branch
from
September 10, 2026 19:31
43e9b64 to
c5230b1
Compare
Author
tgrushka
force-pushed
the
refactor-magnifier-zoom-increments
branch
from
September 10, 2026 19:36
d2b717e to
296d3db
Compare
Author
|
Wait, that didn't work... had to run |
cargo update -p cosmic-comp-config --precise 738e0b312497dec066a611dc5ea98b75df39058e cargo update -p libcosmic --precise 2a73fbc0edfe1525381bf999e241d73def79b222
tgrushka
force-pushed
the
refactor-magnifier-zoom-increments
branch
from
September 10, 2026 20:06
296d3db to
c1ba4fa
Compare
Author
|
Sorry guys, libcosmic HEAD broke things. Just pushed precise updates. |
Member
|
Needs to be rebased still. It shouldn't be necessary to update the Cargo.lock file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
cosmic-compPR #2616 andcosmic-compissue #2615cosmic-comp-configto738e0b3(merged #2616), notHEADlibcosmicby side effect:2a73fbc->caec74cmagnifier.rswith newconst ZoomConfig::ZOOM_INCREMENT_PRESETSadded in #2616The version bump was produced using the following command (
Cargo.lockwas not hand-edited):just check-featuresandjust test --all-featuresboth green.cargo clippyissues were pre-existing.AI Assisted: Claude AI suggested (unsolicited) the updated line; I reviewed, understood, and approved it.