Conversation
Supports pixel size, without units
… scale_bar # Conflicts: # sashimi/processes/streaming_save.py
vigji
approved these changes
Feb 22, 2021
Member
vigji
left a comment
vigji
left a comment
There was a problem hiding this comment.
Good for me, I would merge after trying it out!
Contributor
Author
|
Finally, scale bar also displays units |
Contributor
Author
|
Not sure how to fix the inheritance validator error from the CI agent. It clearly oversmarted us here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a scale bar functionality to the viewer via the
napari.Viewer.scalebar()which is itself implemented as anEventedModelin Napari . Display of scale bar is optional - can by showed/hidden with aQPushButtoninViewingWidget. Display is independent of the mode, and in 3d display mode as well (this is actually completely useless in the current state). Scale is in um as defined byvoxel_sizeproperty ofViewingWidget. Unit display is not yet available from Napari but there are plans to include this soon(ish).