Publish to Open VSX on ggsql-vscode release#146
Conversation
teunbrand
left a comment
There was a problem hiding this comment.
Thanks George! Just for my understanding, this also is triggered whenever we do the main release right, or do we have to do a separate vscode release?
| @@ -0,0 +1,7 @@ | |||
| Copyright 2025 ggsql authors | |||
There was a problem hiding this comment.
This comment is not a blocker:
Can we do the equivalent of symlinking in github so we don't have multiple versions of licences?
In addition, we may want to bump this (here and elsewhere):
| Copyright 2025 ggsql authors | |
| Copyright 2026 ggsql authors |
There was a problem hiding this comment.
Yeah, I think we can have symlinks, that's a good idea. I'll make a followup PR to do it after this is in.
If we make a main release tagged with I believe the intension for now is that we can have separate release streams, potentially all with different version numbers. This could be useful if we want to bump the Python package, or the VSCode extension, to include some new changes without also having to release a new version of the core ggsql binaries. The alternative would be that tagging I don't mind which of the two schemes we land on, I was just following the current Python package setup. We could ask the rest of the group for thoughts? |
|
Thanks for elaborating! It probably needs to be discussed at some point, but that shouldn't block this PR |
This GHA workflow is gated on
vscode/v*repository tags, similar to thepython-release.ymlworkflow.