Merged
Conversation
georgestagg
approved these changes
Apr 23, 2026
Collaborator
georgestagg
left a comment
georgestagg
left a comment
There was a problem hiding this comment.
LGTM!
I really like the hints system to figure out what template to send on the Rust side rather than at runtime in the embedded JS code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #356
This PR updates the Jupiter kernel vegalite output so that it responds to the destination of the plot
Plot pane: resizes to fit
Inline view: adaptive width, fixed 400px height
Anything else (e.g. quarto). min width at 450px below which it begins to shrink rather than adapt
The issue described in #356 was due to interactions between the inline display and the plot pane fit to size implementation