ci: fix docs-only detection by inverting to has-code filter#3559
Merged
zackverham merged 1 commit intomainfrom Feb 19, 2026
Merged
ci: fix docs-only detection by inverting to has-code filter#3559zackverham merged 1 commit intomainfrom
zackverham merged 1 commit intomainfrom
Conversation
The predicate-quantifier feature in dorny/paths-filter is broken: - The action.yml input definition is missing from v3 - Even when fixed, the implementation is wrong: it checks if each FILE matches ALL patterns, not if ALL files match at least one pattern This meant CHANGELOG.md was rejected because it doesn't match LICENSE, .gitignore, etc. - completely defeating the purpose. Fix by inverting the logic: - Instead of "docs-only = all files are docs" (broken) - Use "has-code = any file is NOT a doc" (works with default 'some') This correctly skips CI for docs-only PRs while running it for any PR that touches code. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
0b82c9c to
1a8f150
Compare
christierney
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes docs-only detection which was completely broken due to issues with
dorny/paths-filter'spredicate-quantifierfeature.Problems Found
Missing input definition: The
predicate-quantifierinput isn't declared inaction.ymlfor v3, causing "Unexpected input" warningsaction.ymlBroken implementation: Even when the input is accepted, the implementation is wrong:
patterns.every(aPredicate)checks if a single file matches every pattern)This meant
CHANGELOG.mdwas rejected because it doesn't matchLICENSE,.gitignore, etc.Solution
Invert the logic from detecting "docs-only" to detecting "has-code":
With the default
somequantifier:has-code = trueif any file matches (i.e., any non-doc file exists)has-code == 'true'Test plan
.mdfile changes skip tests🤖 Generated with Claude Code