Skip to content

fix: No longer need to manually calls session$ns() with shinychat#10

Merged
schloerke merged 3 commits intodevfrom
r/feat/no-ns-needed
Jun 3, 2025
Merged

fix: No longer need to manually calls session$ns() with shinychat#10
schloerke merged 3 commits intodevfrom
r/feat/no-ns-needed

Conversation

@gadenbuie
Copy link
Copy Markdown
Contributor

With the latest version of shinychat (will be v0.2.0 release), chat_append_message() and friends handle namespacing in modules

@gadenbuie gadenbuie requested a review from jcheng5 May 15, 2025 17:30
Comment thread r-package/DESCRIPTION Outdated
@schloerke schloerke changed the base branch from main to dev June 3, 2025 17:32
@schloerke schloerke merged commit c0e2180 into dev Jun 3, 2025
16 checks passed
@schloerke schloerke deleted the r/feat/no-ns-needed branch June 3, 2025 17:33
schloerke added a commit that referenced this pull request Jun 5, 2025
* dev:
  feat: genericizing data source using DataSource protocol: Supports SQLAlchemy and Pandas
  fix: No longer need to manually calls `session$ns()` with shinychat (#10)
  Remove website routine, no pkgdown site intended (#18)
@chendaniely chendaniely restored the r/feat/no-ns-needed branch June 6, 2025 22:20
chendaniely added a commit that referenced this pull request Jun 7, 2025
…#27)

This is a re-submission of #10 because the R version is currently broken without it.

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Co-authored-by: Barret Schloerke <barret@posit.co>
@chendaniely chendaniely deleted the r/feat/no-ns-needed branch June 7, 2025 03:05
schloerke added a commit that referenced this pull request Jun 10, 2025
* dev:
  chore!: Restructure folders to align with posit-dev/shinychat (#24)
  feat: genericizing data source using DataSource protocol: Supports SQLAlchemy and Pandas
  fix: No longer need to manually calls `session$ns()` with shinychat (#10)
  Remove website routine, no pkgdown site intended (#18)
cpsievert added a commit that referenced this pull request Dec 18, 2025
Apply text improvements across R and Python documentation:

- Reframe data privacy language: emphasize we're NOT sending raw data
  to LLM for complex math operations
- Soften tone around auto-generated greetings: describe as "downsides"
  rather than "slow, wasteful, and non-deterministic"
- Remove duplicate "under the hood" phrasing
- Add local model example (gpt-oss:20b)
- Use friendlier duckdb function in R (duckdb_read_csv)

Addresses unresolved feedback items #2, #4, #5, #7, #10 from PR #162

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants