Closed
Conversation
...instead of requiring explicit DataSource subclass creation
…provements Plus some improvements: - Cleaner .md file reading code in example apps - Use GPT-4.1 by default, not GPT-4 😬 - Make sqlalchemy required
…-datasource-improvements
* this should significantly speed up schema generation * another speedup * ruff formatting * updating so formatting checks pass
Contributor
Author
|
I have looked at resolving the PR conflict. It is beyond a simple fix for |
Contributor
|
Some background:
I can maybe copy + paste the changes from #26 into a new pr on the new file locations and that might help? It seems they're speed + SQL query improvements? |
Contributor
|
@chendaniely that sounds good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making a PR as I'm getting confused with the branch names. Please feel free to close if the idea is abandoned.