feat: use PG_MODULE_MAGIC_EXT in PostgreSQL 18 and later - #203
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughAdds build-time config header generation for h3_postgis and updates both h3 and h3_postgis init files to conditionally use PG_MODULE_MAGIC_EXT on PostgreSQL 18+ while maintaining PG_MODULE_MAGIC for older PostgreSQL versions. CHANGELOG updated to mention the change. ChangesPostgreSQL 18+ Compatibility
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 25: Fix the typo in the CHANGELOG entry referring to PostgreSQL: update
the release note line that mentions "Use `PG_MODULE_MAGIC_EXT` macro in
PostgreSQL 18 an later ([Andreas Karlsson])" to read "and later" instead of "an
later" so the text becomes "Use `PG_MODULE_MAGIC_EXT` macro in PostgreSQL 18 and
later ([Andreas Karlsson])"; ensure the `PG_MODULE_MAGIC_EXT` mention and author
attribution remain unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2bbad8a7-46be-4e0f-8980-52d94e4bf88d
📒 Files selected for processing (5)
CHANGELOG.mdh3/src/init.ch3_postgis/CMakeLists.txth3_postgis/src/config.h.inh3_postgis/src/init.c
The PG_MODULE_MAGIC_EXT macro was added in PostgreSQL 18 and makes it possible to see which version of the library is actually loaded using pg_get_loaded_modules().
2045995 to
5558840
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
To use Codex here, create an environment for this repo. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@jeltz thank you! |
|
Thanks for the speedy merge! |
The
PG_MODULE_MAGIC_EXTmacro was added in PostgreSQL 18 and makes it possible to see which version of the library is actually loaded usingpg_get_loaded_modules().I updated the change log myself, just tell me if that is against the project practice.