Skip to content

Update dependencies for Ubuntu 22.04#203

Merged
bdach merged 2 commits into
ppy:masterfrom
hwsmm:add-pw
Feb 25, 2025
Merged

Update dependencies for Ubuntu 22.04#203
bdach merged 2 commits into
ppy:masterfrom
hwsmm:add-pw

Conversation

@hwsmm

@hwsmm hwsmm commented Feb 20, 2025

Copy link
Copy Markdown
Collaborator

We now have proper PipeWire and libdecor as GitHub is phasing out Ubuntu 20, so this PR tries to use them and removes a snippet that builds libdecor manually.

Successful run: https://github.com/hwsmm/SDL3-CS/actions/runs/13435741476

@smoogipoo
smoogipoo requested a review from bdach February 21, 2025 08:24
@bdach

bdach commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

We now have proper PipeWire

this part of the sentence scares me like you would NOT believe. what is this needed for?

@hwsmm

hwsmm commented Feb 21, 2025

Copy link
Copy Markdown
Collaborator Author

Context is here: https://discord.com/channels/188630481301012481/589331078574112768/1262590975012765726

I'm fine with not having it. Just came up with it when the workflow got updated, but I think there could be some consumers who want PipeWire backend for audio.

@bdach

bdach commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

ok well what i'm probably going to do is i'm going to test these binaries, see if it doesn't completely wreck audio for whatever freakish reason on my setup, and if it doesn't, then i'm just going to huff a whole bucket of copium that my setup is the only relevant linux setup that anyone could ever use and everything will be fine

@hwsmm

hwsmm commented Feb 21, 2025

Copy link
Copy Markdown
Collaborator Author

Uh... Fedora, Ubuntu, Debian and openSUSE, all of them use PipeWire as a default audio server on their latest version. They usually come with alsa/pulse bridge, so not having PipeWire support isn't a big deal, but it can still be a nice add for potential consumers of this package.

This doesn't affect osu! at all because we never initialize audio subsystem.

@bdach

bdach commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

sure all of that seems sane at the surface, but i've long learned to leave sanity at the door when linux is involved, so i'm gonna test the binaries anyway

@smoogipoo

smoogipoo commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

For more context as to why this is required - the OP is involved in the SDL3 audio backend for o!f which is not mainlined yet (ppy/osu-framework#6002) but which has vocal backing behind it/within the team to replace BASS with. This part should not immediately provide any additional functionality which osu! does not currently already have.

I mostly requested your review for if you wanted to test the libdecor stuff, instead.

@bdach

bdach commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

well, on my pc audio isn't broken, wayland client side decorations via libdecor still appear to work (and still are as ugly as ever), so i'm going to call this good and pretend that everything will be fine and linux is not a fragmented mess

SDL3 audio backend for o!f which is not mainlined yet (ppy/osu-framework#6002) but which has vocal backing behind it/within the team to replace BASS with

i remain as uninterested in this effort as i have been, if not more, because for however many faults you may assign to BASS, at least it is stable, and sdl has been the exact inverse of that to the point of me having zero trust in it anymore and basically expecting every sdl bump to break something.

so at this point i might go as far as to say that a hard constraint for me for mainlining sdl audio anything is that this sdl audio backend should be completely interchangeable with bass audio and toggleable by an envvar or something, so when something invariably breaks (because it will), we can at least point users to a stable fallback in the meantime.

@bdach
bdach merged commit 7155c09 into ppy:master Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants