Fix Waveform not disposing Stream#6152
Merged
Merged
Conversation
peppy
self-requested a review
January 28, 2024 17:47
bdach
self-requested a review
February 2, 2024 12:41
smoogipoo
pushed a commit
to smoogipoo/osu-framework
that referenced
this pull request
Feb 3, 2024
Fix Waveform not disposing Stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this issue a bit back while testing performance of Waveform implementation of #6002.
Having
data.Dispose()in my code hindered the benchmarks from running, and it seemed that the benchmarks used a single stream through its entire session.I assumed that the stream gets disposed somewhere else, but I couldn't find any code for that. This could be my oversight, but writing this PR didn't take much time anyway...