Fix remaining Path aliasing issues by adding support for R32F framebuffer format#6776
Merged
Conversation
smoogipoo
approved these changes
Jul 21, 2026
smoogipoo
left a comment
Contributor
There was a problem hiding this comment.
Works well, lgtm!
The only concern I have is the ordering of the new texture format args, but I can understand why it was done this way and agree it makes sense. Regardless this won't require any changes osu!-side so that's good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
While #6767 is good enough for most cases, there are still cases where it fails. There underlying issue -
Maxblending used for solving path intersections isn't working correctly with our encoded sdf value. It selects max value per component while with our encoded value we would need it to select the color with the first max component.Example:
pixel 1 -
0.5, 0.5, 0.5, 0.5pixel2 -
0.5, 0.6, 0.1, 0.1Current resulted color -
0.5, 0.6, 0.5, 0.5(max per component, blends colors)Desired color -
0.5, 0.6, 0.1, 0.1(green value is bigger - full pixel2 color should be the result)Solution
By adding support for R32F (32-bit single-channel) texture format
Maxwill work as expected since there's only a single value to compare. We also can store 32-bit float SDF directly in the texture without encoding/decoding step with the same memory usage per texture.Performance:
Tested with the most complex aspire slider I could find (tens of thousands of vertices) and it's basically the same
Tested on windows with all 3 renderers, mobile/mac probably needs testing as well.