Add a custom shader for BeatmapBackground to handle background dim colour changes#344
Draft
Uncomfy wants to merge 16 commits into
Draft
Add a custom shader for BeatmapBackground to handle background dim colour changes#344Uncomfy wants to merge 16 commits into
Uncomfy wants to merge 16 commits into
Conversation
…instead of a single float
…avoid confusion with existing BeatmapBackground class
…ming that uses v_Colour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles dimming applied directly to BeatmapBackground separately, allowing to change dim colour. Dimming applied by other sources (like overlays) works the same as in a regular texture shader and is not affected by DimColour.
Companion to ppy/osu#30391