Cut some notification samples to remove echo on the end#396
Closed
unststable wants to merge 1 commit into
Closed
Conversation
notification sounds to remove echo on the endnotification samples to remove echo on the end
Member
|
why? |
Author
it sounds a bit better imo |
Member
|
@nekodex can you double check and action on this one (merge or close either is fine). |
Contributor
|
Thanks for bringing this up, however simply truncating the samples cuts the reverb prematurely. I've gone and done a quick fix+enhance pass on the affected samples here, which gets rid of the stray delay/echo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pretty simple change to the
notification-cancel,notification-doneandnotification-errorsounds, cutted it on the end for echo removal.2025-12-12.15-11-24.mp4