Skip to content

Cut some notification samples to remove echo on the end#396

Closed
unststable wants to merge 1 commit into
ppy:masterfrom
unststable:master
Closed

Cut some notification samples to remove echo on the end#396
unststable wants to merge 1 commit into
ppy:masterfrom
unststable:master

Conversation

@unststable

@unststable unststable commented Dec 12, 2025

Copy link
Copy Markdown

This is pretty simple change to the notification-cancel, notification-done and notification-error sounds, cutted it on the end for echo removal.

2025-12-12.15-11-24.mp4

@unststable unststable changed the title Cut some notification sounds to remove echo on the end Cut some notification samples to remove echo on the end Dec 12, 2025
@peppy

peppy commented Dec 12, 2025

Copy link
Copy Markdown
Member

why?

@unststable

unststable commented Dec 12, 2025

Copy link
Copy Markdown
Author

why?

it sounds a bit better imo
plus if you compare with notification-default, there is no echo

@peppy
peppy requested a review from nekodex December 12, 2025 14:42
@peppy

peppy commented May 21, 2026

Copy link
Copy Markdown
Member

@nekodex can you double check and action on this one (merge or close either is fine).

@nekodex

nekodex commented May 29, 2026

Copy link
Copy Markdown
Contributor

Thanks for bringing this up, however simply truncating the samples cuts the reverb prematurely.

I've gone and done a quick fix+enhance pass on the affected samples here, which gets rid of the stray delay/echo.

@nekodex nekodex closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants