Dynamically load GEOSPreparedContainsXY where available#4
Open
dbaston wants to merge 1 commit intopramsey:masterfrom
Open
Dynamically load GEOSPreparedContainsXY where available#4dbaston wants to merge 1 commit intopramsey:masterfrom
dbaston wants to merge 1 commit intopramsey:masterfrom
Conversation
pramsey
reviewed
Sep 13, 2022
|
|
||
| log_stderr("VERSION [GEOS %s]\n", GEOSversion()); | ||
|
|
||
| geos_lib_handle = dlopen("libgeos_c.so", RTLD_LAZY); |
Owner
There was a problem hiding this comment.
Hm, will need to do something about file extensions, "libgeos_c.dylib" is what I've got. There is a dlopen() documented so that part might work. I will experiemnt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to update
geos-performanceso we can look at how libgeos/geos#674 affects point-in-polygon performance assuming that client code is updated to useGEOSPreparedContainsXY.It works well for me and gives the desired "no impact on performance" answer. I don't know what you think about the complexity it adds, or how if this code even runs on MacOS. But I think this presents an alternative to the "only use functions available in the oldest version you want to test" limitation.