-
Notifications
You must be signed in to change notification settings - Fork 44
refactor(callouts): normalize outbound failure-policy configuration #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
r-papso
wants to merge
14
commits into
praxis-proxy:main
Choose a base branch
from
r-papso:refactor/outbound-failure-policy-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ab761d5
refactor(callouts): consolidate outbound failure policy into shared m…
r-papso 99e6b95
refactor(callouts): rename provider_failure_mode to on_failure
r-papso b18feee
refactor(callouts): rename callout_failure_mode to on_failure
r-papso 3511f9e
refactor(callouts): reuse shared FailureMode in http_callout
r-papso 555f5a1
chore(callouts): fix up formatting and doc-generation after the rename
r-papso c01a09c
docs(migrating): document the on_failure rename for 0.2.0
r-papso 45dc2c7
refactor(web-search): use shared timeout and status validators
r-papso c5542aa
docs(callouts): describe callout policy enums as a vocabulary
r-papso f9d6d02
refactor(callouts): use the shared status_on_error validator in http_…
r-papso 20c792a
docs(callouts): trim the shared policy docs to the vocabulary
r-papso b49a237
Merge branch 'main' into refactor/outbound-failure-policy-config
r-papso bf183fb
refactor(callouts): rename FailureMode to OnFailure
r-papso 57ef807
docs(migrating): move the callout key rename to the 0.3.0 guide
r-papso 34d0318
chore(callouts): linting, formatting
r-papso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(ai): "callout_policy.rs describes OnMissing as applying when a callout succeeds and reports a missing resource. openai_file_resolve resolve_reference at apis/src/openai/responses/file_resolve/resolve.rs:666-668 treats on_missing: continue as pass-through for any file_id resolution error except TooManyReferences, including transport, timeout, non-2xx, parsing, and size failures—not only a successful 404-style absence. Filter docs (openai_file_resolve.md line 24) say cannot be fetched, which is closer to behavior than the shared enum doc. The shared vocabulary should either document this widening explicitly or narrow the enum description to filter-specific semantics with a cross-reference to file_resolve."
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. I updated the docs to state that
OnMissingcontrols "What happens when a requested resource cannot be fetched". That indeed more closely maps tofile_resolve.rswhich is for now only filter using it. The enum's purpose and docs description can be widened in the future, if needed.