fix(compact): require allow_pre_security_callout for StreamBuffer callouts - #849
Open
mkoushni wants to merge 1 commit into
Open
fix(compact): require allow_pre_security_callout for StreamBuffer callouts#849mkoushni wants to merge 1 commit into
mkoushni wants to merge 1 commit into
Conversation
…louts Summarization runs in the pre-read body phase, before same-chain header-phase auth. Match file_resolve/doc_extract: default false and refuse construction unless the operator acknowledges an outer trust boundary. Signed-off-by: mkoushni <mkoushni@redhat.com>
mkoushni
force-pushed
the
fix/660-compact-pre-security-callout
branch
from
September 1, 2026 16:35
4491f31 to
a20217b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamBufferpre-read body phase, before same-chain header-phase authentication. Unlikefile_resolveanddoc_extract, construction did not require an explicit opt-in, so an unauthenticated continuation could burn the configured inference backend.allow_pre_security_callout(defaultfalse) and refuse filter construction unless it istrue. Document that an outer listener or network trust boundary must authenticate first.examples/configs/openai/responses/compact.yaml.Fixes #660
Test plan
cargo test -p praxis-ai-apis --lib compact(missing ack rejected; explicittrueconstructs)cargo test -p praxis-tests-integration compact(example passthrough + multi-turn)make coverage-check(95.41% line coverage)