docs(proposals): Live request tap API (SSE streaming) (#792) - #5
docs(proposals): Live request tap API (SSE streaming) (#792)#5henschwartz wants to merge 1 commit into
Conversation
praxis-bot
left a comment
There was a problem hiding this comment.
PR Review
Summary: The proposal is well-structured and clearly motivates the need for live request tap on the admin listener. The SSE design and server-side filtering approach are sound. However, critical failure modes (event dropping under rate limits, backpressure behavior) and the architectural approach to achieving "zero overhead when no clients connected" are not addressed, leaving feasibility questions open.
| Severity | Count |
|---|---|
| Large | 1 |
| Medium | 2 |
773d30c to
f98366c
Compare
praxis-bot
left a comment
There was a problem hiding this comment.
PR Review
Summary: The proposal comprehensively addresses all previous review findings on max_rps overflow behavior, zero-overhead architecture, and default value rationale. The Goals, Decisions, and graduation criteria are now clear and actionable. However, two operational details remain underspecified: the HTTP status code for max_clients rejection and the client experience when disconnected due to slow send buffer.
| Severity | Count |
|---|---|
| Medium | 2 |
Signed-off-by: Hen Schwartz <hschwart@redhat.com>
f98366c to
f452767
Compare
Summary
What/Why proposal for #792:
GET /api/tapSSE on the admin listener for live request metadata with server-side filters and zero overhead when no clients are connected.Test plan
proposal-checkCI passes (frontmatter, no## How?)