Skip to content

docs(proposals): Live request tap API (SSE streaming) (#792) - #5

Open
henschwartz wants to merge 1 commit into
praxis-proxy:mainfrom
henschwartz:proposal/00792-live-request-tap-api
Open

docs(proposals): Live request tap API (SSE streaming) (#792)#5
henschwartz wants to merge 1 commit into
praxis-proxy:mainfrom
henschwartz:proposal/00792-live-request-tap-api

Conversation

@henschwartz

Copy link
Copy Markdown

Summary

What/Why proposal for #792: GET /api/tap SSE on the admin listener for live request metadata with server-side filters and zero overhead when no clients are connected.

Test plan

  • proposal-check CI passes (frontmatter, no ## How?)
  • Maintainer review of Decisions (status/path glob, client limits, SSE keepalive)

@henschwartz henschwartz changed the title Live request tap API (SSE streaming) (#792) docs(proposals): Live request tap API (SSE streaming) (#792) Aug 27, 2026

@praxis-bot praxis-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

Summary: The proposal is well-structured and clearly motivates the need for live request tap on the admin listener. The SSE design and server-side filtering approach are sound. However, critical failure modes (event dropping under rate limits, backpressure behavior) and the architectural approach to achieving "zero overhead when no clients connected" are not addressed, leaving feasibility questions open.

Severity Count
Large 1
Medium 2

Comment thread proposals/00792_live-request-tap-api.md
Comment thread proposals/00792_live-request-tap-api.md
Comment thread proposals/00792_live-request-tap-api.md Outdated
@shaneutt shaneutt self-assigned this Aug 28, 2026
@shaneutt shaneutt moved this from Next to Review in Core Proxy Aug 28, 2026
@henschwartz
henschwartz force-pushed the proposal/00792-live-request-tap-api branch from 773d30c to f98366c Compare August 31, 2026 07:18

@praxis-bot praxis-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

Summary: The proposal comprehensively addresses all previous review findings on max_rps overflow behavior, zero-overhead architecture, and default value rationale. The Goals, Decisions, and graduation criteria are now clear and actionable. However, two operational details remain underspecified: the HTTP status code for max_clients rejection and the client experience when disconnected due to slow send buffer.

Severity Count
Medium 2

Comment thread proposals/00792_live-request-tap-api.md Outdated
Comment thread proposals/00792_live-request-tap-api.md Outdated
Signed-off-by: Hen Schwartz <hschwart@redhat.com>
@henschwartz
henschwartz force-pushed the proposal/00792-live-request-tap-api branch from f98366c to f452767 Compare September 1, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

3 participants