docs(proposals): Admin Dashboard and Stats API (#125) - #6
Conversation
henschwartz
changed the title
praxis-bot
left a comment
praxis-bot
left a comment
There was a problem hiding this comment.
PR Review
Summary: The proposal effectively coordinates the Admin Dashboard umbrella (#125) and maps already-shipped sibling capabilities. The phased delivery structure is clear. However, Phase 1 v1 scope is ambiguous on two critical points: which listener types provide connection stats, and which filters have execution counters. Stakeholders cannot assess v1 completeness without this information.
| Severity | Count |
|---|---|
| Large | 1 |
| Medium | 1 |
0f1c819 to
3e86ec9
Compare
praxis-bot
left a comment
praxis-bot
left a comment
There was a problem hiding this comment.
PR Review
Summary: The proposal effectively addresses previous review findings on filter counter scope and listener-type coverage. The phased delivery structure and Decisions section are now comprehensive. However, two Phase 1 v1 deliverables remain underspecified: "version identity" and "endpoint health summary" are listed in graduation criteria but never defined in the proposal body or Decisions.
| Severity | Count |
|---|---|
| Medium | 2 |
Signed-off-by: Hen Schwartz <hschwart@redhat.com>
3e86ec9 to
004cb47
Compare
3 participants
Summary
Umbrella What/Why for #125: maps already-landed observability admin APIs (#794, #796, #798, …) and proposes phased delivery starting with
GET /api/statsJSON.Test plan
proposal-checkCI passes/metricsboundary