test(quota): wait for serving overlay revision - #120
Merged
nerdalert merged 1 commit intoSep 4, 2026
Conversation
Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The distributed token-quota integration test previously began traffic after Grid had published valid overlays, but it did not prove that both Praxis consumer gateways had loaded and were serving that exact revision. During initial convergence, this could make otherwise-correct routing and distribution assertions run against stale gateway state.
This change replaces that accepted-overlay-only check with a serving-revision convergence gate.
Before quota traffic starts, the test now requires both west consumer gateways to report:
roundRobinoverlay from Grid;The polling remains state-based and bounded to 240 seconds. A timeout reports the last observed Grid, Praxis accepted, and Praxis serving revision for each gateway, which makes bootstrap and reload failures diagnosable without weakening the qualification.
Parsing and coverage
Praxis revision fields are read from the current gateway logs after ANSI SGR sequences are removed. Field matching requires an exact whitespace boundary, so
serving_revisioncannot be taken fromprevious_serving_revisionorretained_serving_revision. Quoted and unquoted field values are supported.Seven focused tests cover:
previous_serving_revision;The existing authentication, quota, candidate, routing, and cleanup assertions are unchanged.
Validation
The first isolated Kind run passed all 10 token-quota scenarios:
A separate repeatability run was started independently and is not claimed by this PR description until its evidence completes.
Scope
Only
xtask/src/env/token_rate_limit_qualification.rsis committed. Generated Forge resolution files and runtime evidence directories were deliberately excluded. No Grid production controller, overlay, routing, AI, Praxis, topology, or policy code is changed.