test(CEL-PDP)--collision-precedence-rules-(stdlib-shadowing,-bag-name… - #58
Open
Conversation
Collaborator
|
@aviavissar - Please fix the DCO |
…space-vs-scalar)-lack-test-coverage-praxis-proxy#3 Signed-off-by: aviavissar <aviavissar@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
aviavissar
force-pushed
the
test(CEL-PDP)--collision-precedence-rules-(stdlib-shadowing,-bag-namespace-vs-scalar)-lack-test-coverage-#3
branch
from
September 1, 2026 12:57
92a8984 to
a7a14e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssue: praxis-proxy/policy#3 — CEL PDP collision-precedence rules had no tests. Not a runtime bug; the code already exists.
What landed (on branch test(CEL-PDP)--collision-precedence-rules-(stdlib-shadowing,-bag-namespace-vs-scalar)-lack-test-coverage-#3, uncommitted):
activation.rs — namespace_wins_when_scalar_arrives_after_branch
Pins the untested insert path: delegation.depth first, then scalar delegation. Namespace wins, scalar is dropped. Calls insert directly so HashMap iteration order cannot miss that path.
resolver.rs — custom_function_does_not_shadow_stdlib_size
Registers a custom size that would return 777. Stdlib still runs (size('hello') == 5). rustdoc on with_functions now states that as of cel 0.14 the stdlib overload wins.
No behavior change. Tests passed.