chore(docs): updated license badge

[nirrozenbaum]

What does this PR do?

license was updated from MIT to Apache 2.0, update license badge accordingly.

Which issue(s) does this relate to?

Fixes #

Checklist

• Signed off all commits (git commit -s)
• Tests added or updated
• Documentation updated (if applicable)
• make lint && make test passes locally

Does this introduce a breaking change?

no

[praxis-bot-app]

Commit message format: the following commits do not follow conventional commits:

• 7ab660d: updated license badge

Expected format: type(scope): summary (max 72 chars). Types: build, chore, ci, docs, feat, fix, perf, refactor, test.

[leseb]

Hum I'm wondering if we shouldn't remove the badge instead, since it's part of the README tab on GitHub anyway.

Thoughts?

[nirrozenbaum]

Hum I'm wondering if we shouldn't remove the badge instead, since it's part of the README tab on GitHub anyway.

Thoughts?

good question. it's a common practice to include the license badge on the main README.md (I've seen it in almost every CNCF project I looked at). in all those projects it's possible to see License on the sidebar and still most projects use the badge. so this is aligned with other CNCF projects.

of course, up to the maintainers of praxis. if you prefer to remove I can remove the badge :)

non blocking

[leseb]

Hum I'm wondering if we shouldn't remove the badge instead, since it's part of the README tab on GitHub anyway.
Thoughts?

good question. it's a common practice to include the license badge on the main README.md (I've seen it in almost every CNCF project I looked at). in all those projects it's possible to see License on the sidebar and still most projects use the badge. so this is aligned with other CNCF projects.

of course, up to the maintainers of praxis. if you prefer to remove I can remove the badge :)

fair enough :)

[nirrozenbaum]

fixed in 2180d88