Handle JSON string source maps returned from rollup plugins#783
Open
Aeriit wants to merge 1 commit intopreactjs:mainfrom
Open
Handle JSON string source maps returned from rollup plugins#783Aeriit wants to merge 1 commit intopreactjs:mainfrom
Aeriit wants to merge 1 commit intopreactjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: c02209b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
marvinhagemeister
left a comment
marvinhagemeister
left a comment
There was a problem hiding this comment.
Looking good! Let's add a test case for this so we don't run the risk of regressing on this behavior here.
For that you can create a new sample project in the fixture directory and add a simple noop plugin, that returns a string for the map property. There are a few examples on how to run those fixtures from our test suite in ´fixtures.test.js`
| try { | ||
| result.map = JSON.parse(result.map); | ||
| } catch { | ||
| if (hasDebugFlag()) { |
Member
There was a problem hiding this comment.
No need to wrap this with hasDebugFlag(). That check is already part of logTransform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some rollup plugins (such as rollup-plugin-esbuild) return the source map as a string instead of an object; this string needs to be parsed before we can normalize the source URLs (because right now it throws a "cannot read property 'map' of undefined").