test: add 16 unit tests for scorePrompt covering all scoring dimensions - #132
Closed
TerminalGravity wants to merge 1 commit into
Closed
test: add 16 unit tests for scorePrompt covering all scoring dimensions#132TerminalGravity wants to merge 1 commit into
TerminalGravity wants to merge 1 commit into
Conversation
- Export scorePrompt function for testability - Test all 4 scoring dimensions: specificity, scope, actionability, done-condition - Test grade assignment (A+ through F) - Test feedback generation for low/high scoring prompts - Verify total equals sum of dimensions
TerminalGravity
commented
Mar 6, 2026
TerminalGravity
left a comment
TerminalGravity
left a comment
Collaborator
Author
There was a problem hiding this comment.
Tests look solid — good coverage across all four scoring dimensions plus grade boundaries. One minor note: the engine bump to node>=20 in package-lock.json looks like it snuck in from another branch. If intentional, worth calling out in the PR description. Otherwise LGTM.
Collaborator
Author
|
Closing — superseded by a newer version of this test PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive unit test coverage for the
scorePromptfunction inprompt-score.ts.Changes:
scorePromptfor direct testability