test: add prompt-score and estimate-cost unit tests (+28 tests) - #20
Closed
TerminalGravity wants to merge 1 commit into
Closed
test: add prompt-score and estimate-cost unit tests (+28 tests)#20TerminalGravity wants to merge 1 commit into
TerminalGravity wants to merge 1 commit into
Conversation
Collaborator
Author
|
✅ Reviewed — good coverage. Tests verify each scoring dimension independently and check grade boundaries. The minimal export change is correct. Ready to merge. |
TerminalGravity
commented
Feb 27, 2026
TerminalGravity
left a comment
TerminalGravity
left a comment
Collaborator
Author
There was a problem hiding this comment.
Good prompt-score coverage. LGTM 👍
TerminalGravity
force-pushed
the
test/prompt-score-coverage
branch
from
March 2, 2026 20:45
2d20f5f to
cf93e32
Compare
TerminalGravity
changed the title
Export scorePrompt() and add comprehensive tests covering: - All four scoring dimensions (specificity, scope, actionability, done-condition) - Grade boundaries (A+ for excellent, D/F for vague) - Feedback generation (improvement tips vs congratulatory) - Score arithmetic invariant (dimensions sum to total) Bumps test count from 43 → 58.
TerminalGravity
force-pushed
the
test/prompt-score-coverage
branch
from
March 4, 2026 00:45
cf93e32 to
9d46dcf
Compare
Collaborator
Author
|
Superseded by newer PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps test count from 43 → 71.
scorePrompt()so it can be unit tested directlyNo behavior changes — just testability and coverage.