fix: replace run() misuse with shell() or array args across 9 tools - #217
Closed
TerminalGravity wants to merge 1 commit into
Closed
fix: replace run() misuse with shell() or array args across 9 tools#217TerminalGravity wants to merge 1 commit into
TerminalGravity wants to merge 1 commit into
Conversation
Collaborator
Author
|
Superseded by #220, which has the same fixes with cleaner organization. Recommend closing this one. |
Fixes #215. The git.ts run() function uses execFileSync('git', args), so passing non-git commands, pipes, redirects, or redundant 'git' prefixes caused silent failures. Changes: - Add shell() helper in lib/git.ts for commands needing pipes/redirects - Fix verify-completion: use readFileSync for package.json, shell() for tsc/build/test commands, proper run() args for git diff - Fix clarify-intent: shell() for tsc and find commands - Fix session-handoff: shell() for command -v and gh CLI calls - Fix audit-workspace: proper run() args, shell() for find - Fix sharpen-followup: array args for git diff/status calls - Fix enrich-agent-task: replace piped run() with Node fs/Array APIs - Fix sequence-tasks: run(['ls-files']) + JS slice instead of pipes - Fix checkpoint: run() with array args, shell() for compound commands - Fix scope-work: proper run() args, JS regex instead of grep pipes
TerminalGravity
force-pushed
the
fix/run-misuse-215
branch
from
March 12, 2026 15:23
724935f to
1ac4826
Compare
Collaborator
Author
|
Closing — superseded by #220. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #215 —
run()inlib/git.tsusesexecFileSync('git', args), so passing non-git commands, shell pipes, redirects, or redundantgitprefixes caused silent failures across 9 tools.Changes
lib/git.ts: Addshell()helper usingexecSyncfor commands needing pipes/redirectsTesting
npm run build— clean ✅npm test— 43/43 pass ✅