refactor: extract preflight-check helpers into testable module - #23
Closed
TerminalGravity wants to merge 1 commit into
Closed
refactor: extract preflight-check helpers into testable module#23TerminalGravity wants to merge 1 commit into
TerminalGravity wants to merge 1 commit into
Conversation
- Extract extractFilePaths, detectAmbiguity, estimateComplexity, classifyRisk, splitSubtasks into src/lib/preflight-helpers.ts - Update preflight-check.ts to import from helpers module - Add 22 tests covering all extracted helper functions - All 65 tests passing (up from 43)
Collaborator
Author
|
🚧 Needs rebase on #17 before merge. Good refactor direction — extracting pure functions for testability is the right call. But the Please rebase on #17 so the extracted helper includes the filtering logic. Otherwise we regress on path extraction quality. Rest of the extraction looks clean — detectAmbiguity, estimateComplexity, classifyRisk, splitSubtasks are all well-structured. |
Collaborator
Author
|
Superseded by #29 which includes these changes plus the dotfile bug fix and additional tests. Closing in favor of that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the 5 core pure functions from
preflight-check.tsintosrc/lib/preflight-helpers.tsso they can be unit tested without mocking the MCP server.Changes:
src/lib/preflight-helpers.tswith:extractFilePaths,detectAmbiguity,estimateComplexity,classifyRisk,splitSubtaskspreflight-check.tsupdated to import from helpers (no behavior change)tests/lib/preflight-helpers.test.tsLays groundwork for #7 (unified preflight_check) by making the core logic independently testable.