fix: what_changed tool passes shell operators to execFileSync - #231
Open
TerminalGravity wants to merge 1 commit into
Open
fix: what_changed tool passes shell operators to execFileSync#231TerminalGravity wants to merge 1 commit into
TerminalGravity wants to merge 1 commit into
Conversation
The run() helper uses execFileSync (no shell), so shell operators like 2>/dev/null and || were being passed as literal git args, causing incorrect results. Replace with proper array-based calls and reuse existing getDiffFiles() helper which already handles fallback logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
what_changedwas passing strings with shell operators (2>/dev/null,||) torun(), which usesexecFileSync(no shell). The operators were being split on whitespace and passed as literal git arguments, producing wrong results or errors.Fix
run()calls instead of shell command stringsgetDiffFiles()helper which already handles fallback logicgit logrange queriesBuild passes, all 43 tests green.