refactor: extract preflight-check helpers + fix false-positive file path matching - #24
Closed
TerminalGravity wants to merge 1 commit into
Closed
refactor: extract preflight-check helpers + fix false-positive file path matching#24TerminalGravity wants to merge 1 commit into
TerminalGravity wants to merge 1 commit into
Conversation
…e-positive file path matching - Extract extractFilePaths, detectAmbiguity, estimateComplexity, splitSubtasks into src/lib/preflight-helpers.ts for testability - Fix extractFilePaths matching version strings (v3.2.0), abbreviations (e.g.), and framework names (node.js) as file paths - Add allowlist of real file extensions to reduce false positives - Add 18 new tests in tests/lib/preflight-helpers.test.ts - All 61 tests pass
Collaborator
Author
|
Superseded by #29 which consolidates this work with additional improvements. Closing in favor of that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
extractFilePaths,detectAmbiguity,estimateComplexity,splitSubtasksfrompreflight-check.tsintosrc/lib/preflight-helpers.tsextractFilePathswas matching version strings (v3.2.0), abbreviations (e.g.,i.e.), and framework names (node.js) as file pathsWhy
The helpers were untestable as private functions. The file path regex was producing false positives that could confuse triage (e.g.
v3.2.0being treated as a referenced file → bogus 'file not found' warnings).All 61 tests pass ✅