fix: clarify-intent misses plural 'tests'/'specs' + add unit tests - #247
Open
TerminalGravity wants to merge 1 commit into
Open
fix: clarify-intent misses plural 'tests'/'specs' + add unit tests#247TerminalGravity wants to merge 1 commit into
TerminalGravity wants to merge 1 commit into
Conversation
- extractSignals regex used \b(test|spec)\b which fails on plurals - Changed to tests?/specs? so 'run the tests' correctly triggers TESTS signal - Exported extractSignals for testability - Added comprehensive test suite for all intent patterns
TerminalGravity
commented
Mar 13, 2026
TerminalGravity
left a comment
TerminalGravity
left a comment
Collaborator
Author
There was a problem hiding this comment.
The tests?/specs? regex fix is obviously correct — surprised we missed plural forms. Good test coverage on the plural cases. Clean PR. ✅
TerminalGravity
commented
Mar 16, 2026
TerminalGravity
left a comment
TerminalGravity
left a comment
Collaborator
Author
There was a problem hiding this comment.
Makes sense — plurals like 'tests' and 'specs' are common in real prompts. Tests look solid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
extractSignalsregex used\b(test|spec)\bwhich doesn't match plurals like 'tests' or 'specs'. Changed totests?/specs?.extractSignalscovering all intent patterns, context hints, multi-intent detection, and the plural fix.Why
Saying 'run the tests' wouldn't trigger the TESTS intent signal — only 'run the test' would. Common phrasing was silently falling through to UNCLEAR.
Test